Skip to content

[integration]: Deepeval logger - #10382

Closed
spike-spiegel-21 wants to merge 11 commits into
BerriAI:mainfrom
spike-spiegel-21:deepeval_logger
Closed

spike-spiegel-21 wants to merge 11 commits into
BerriAI:mainfrom
spike-spiegel-21:deepeval_logger

Conversation

@spike-spiegel-21

@spike-spiegel-21 spike-spiegel-21 commented Apr 28, 2025 •

Copy link
Copy Markdown
Contributor

Deepeval (Confidential AI) integration with LiteLLM's trace callback

DeepEval is an open-source evaluation framework for LLMs (Github).

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature

Changes

  1. New integration
  2. Docs
  3. Test cases

Screenshot for new test passing locally:
image

@vercel

vercel Bot commented Apr 28, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 6:18am

@CLAassistant

CLAassistant commented Apr 28, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ghost

ghost commented Apr 28, 2025

Copy link
Copy Markdown

Hi @spike-spiegel-21, please do not delete our contribution guidelines.

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

@spike-spiegel-21

Copy link
Copy Markdown
Contributor Author

Hey @krrishdholakia, Apologies. We have accommodated all the contribution guidelines.

# Class variables or attributes
def __init__(self) -> None:
try:
from deepeval.tracing.tracing import ToolAttributes

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @spike-spiegel-21 can we please use an httpx implementation here instead.

It will be difficult for proxy users to use deepeval, if it requires additional dependencies.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if deepeval is otel compatible, you can implement it similar to arize -

class ArizePhoenixLogger:

@spike-spiegel-21 spike-spiegel-21 May 2, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @krrishdholakia, nice observation. currently we do not have a dedicated httpx implementation. However, we have mentioned the dependency requirement in the proxy docs.

No, we are not OTEL compatible at the moment.

@spike-spiegel-21

Copy link
Copy Markdown
Contributor Author

closing this as planned in this PR: #10649

This branch was successfully deployed

1 active deployment
Preview — e41f4c33 Deployed May 2, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants